Re: [linux-sunxi] Re: [PATCH 0/7] Pine64 PineCube support

From: Clément Péron
Date: Sat Oct 03 2020 - 09:37:59 EST


Hi Icenowy,

On Sat, 3 Oct 2020 at 12:39, Icenowy Zheng <icenowy@xxxxxxx> wrote:
>
>
>
> 于 2020年10月3日 GMT+08:00 下午6:28:03, "Clément Péron" <peron.clem@xxxxxxxxx> 写到:
> >Hi,
> >
> >I was running dtbs_check and found this series introduced new warnings.
> >
> > DTC arch/arm/boot/dts/sun8i-s3-pinecube.dtb
> > DTC arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml
> > CHECK arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible: ['allwinner,sun8i-v3s-system-control',
> >'allwinner,sun8i-h3-system-control'] is not valid under any of the
> >given schemas (Possible causes of the failure):
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible: Additional items are not allowed
> >('allwinner,sun8i-h3-system-control' was unexpected)
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun4i-a10-sram-controller' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun5i-a13-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun7i-a20-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun8i-a23-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun8i-h3-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun8i-r40-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun50i-a64-sram-controller' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun50i-a64-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun50i-h5-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun50i-h6-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,suniv-f1c100s-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:1: 'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:1: 'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:1: 'allwinner,sun50i-a64-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:1: 'allwinner,sun4i-a10-system-control' was expected
> >
> >From schema:
> >/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: camera@1cb4000: port:
> >'#address-cells', '#size-cells' do not match any of the regexes:
> >'pinctrl-[0-9]+'
> >From schema:
> >/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml
>
> Is this broken schema?

I think the #address-cells', '#size-cells' are not required here.
I had a quick look at other csi and nobody seems to specify this.

Just FYI This is what I did.
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master
ARCH=arm make sunxi_defconfig
ARCH=arm make -j8 dtbs_check

Regards,
Clement

> >
> >And also some other boards
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:
> >['allwinner,sun8i-v3s-system-control',
> >'allwinner,sun8i-h3-system-control'] is not valid under any of the
> >given schemas (Possible causes of the failure):
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible: Additional items are not allowed
> >('allwinner,sun8i-h3-system-control' was unexpected)
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun4i-a10-sram-controller' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun5i-a13-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun7i-a20-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun8i-a23-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun8i-h3-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun8i-r40-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-a64-sram-controller' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-a64-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-h5-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-h6-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,suniv-f1c100s-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun50i-a64-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun4i-a10-system-control' was expected
> >
> >From schema:
> >/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:
> >['allwinner,sun8i-v3s-system-control',
> >'allwinner,sun8i-h3-system-control'] is not valid under any of the
> >given schemas (Possible causes of the failure):
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible: Additional items are not allowed
> >('allwinner,sun8i-h3-system-control' was unexpected)
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun4i-a10-sram-controller' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun5i-a13-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun7i-a20-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun8i-a23-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun8i-h3-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun8i-r40-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-a64-sram-controller' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-a64-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-h5-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-h6-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,suniv-f1c100s-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun50i-a64-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun4i-a10-system-control' was expected
> >
> >From schema:
> >/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:
> >['allwinner,sun8i-v3s-system-control',
> >'allwinner,sun8i-h3-system-control'] is not valid under any of the
> >given schemas (Possible causes of the failure):
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible: Additional items are not allowed
> >('allwinner,sun8i-h3-system-control' was unexpected)
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun4i-a10-sram-controller' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun5i-a13-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun7i-a20-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun8i-a23-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun8i-h3-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun8i-r40-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-a64-sram-controller' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-a64-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-h5-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-h6-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,suniv-f1c100s-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun50i-a64-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun4i-a10-system-control' was expected
> >
> >Regards,
> >Clement
> >
> >On Fri, 25 Sep 2020 at 17:12, Maxime Ripard <maxime@xxxxxxxxxx> wrote:
> >>
> >> Hi,
> >>
> >> On Wed, Sep 23, 2020 at 08:57:02AM +0800, Icenowy Zheng wrote:
> >> > Pine64 PineCube is an IP camera based on Allwinner S3 chip.
> >> >
> >> > This patchset tries to add support for it.
> >> >
> >> > In order to make sure the system do not hang when camera is brought
> >up,
> >> > a fix to AXP209 driver is needed (sent individually), otherwise the
> >> > system will hang because it changes the voltage of LDO2 when LDO4
> >> > tweaking.
> >>
> >> Queued all the patches for 5.11
> >>
> >> > Icenowy Zheng (7):
> >> > ARM: dts: sun8i: V3/V3s/S3/S3L: add Ethernet support
> >> > ARM: dts: sun8i: V3/V3s/S3/S3L: add pinctrl for UART2 RX/TX
> >> > ARM: dts: sun8i: V3/V3s/S3/S3L: add CSI1 device node
> >> > ARM: dts: sun8i: V3/V3s/S3/S3L: add pinctrl for 8-bit parallel
> >CSI
> >> > ARM: dts: sun8i: V3/V3s/S3/S3L: add pinctrl for I2C1 at PE bank
> >> > dt-bindings: arm: sunxi: add Pine64 PineCube binding
> >> > ARM: dts: sun8i: s3l: add support for Pine64 PineCube IP camera
> >>
> >> However, I guess for the next patches to the v3s DTSI we should just
> >> have a simpler prefix (like v3), it's really taking a lot of
> >characters
> >> here :)
> >>
> >> Maxime
> >>
> >> --
> >> You received this message because you are subscribed to the Google
> >Groups "linux-sunxi" group.
> >> To unsubscribe from this group and stop receiving emails from it,
> >send an email to linux-sunxi+unsubscribe@xxxxxxxxxxxxxxxx.
> >> To view this discussion on the web, visit
> >https://groups.google.com/d/msgid/linux-sunxi/20200925151241.kfmytlff4grswtzh%40gilmour.lan.