Re: [PATCH V3 1/2] bindings: media: gpio-ir-receiver: add linux,autosuspend-period property

From: Sean Young
Date: Sat Oct 03 2020 - 04:47:02 EST


On Tue, Sep 29, 2020 at 10:52:01AM -0500, Rob Herring wrote:
> On Wed, Sep 23, 2020 at 03:08:06AM +0800, Joakim Zhang wrote:
> > Add linux,autosuspend-period property for gpio ir receiver. Some cpuidle
> > systems wake from idle may take a bit long time, for such case, need
> > disable cpuidle temporarily.
> >
> > Signed-off-by: Joakim Zhang <qiangqing.zhang@xxxxxxx>
> > ---
> > ChangeLogs:
> > V1->V2:
> > * New add.
> > V2->V3:
> > * linux,autosuspend-period = 125; -> linux,autosuspend-period = <125>;
> > ---
> > Documentation/devicetree/bindings/media/gpio-ir-receiver.txt | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/gpio-ir-receiver.txt b/Documentation/devicetree/bindings/media/gpio-ir-receiver.txt
> > index 58261fb7b408..e1447c9b0e26 100644
> > --- a/Documentation/devicetree/bindings/media/gpio-ir-receiver.txt
> > +++ b/Documentation/devicetree/bindings/media/gpio-ir-receiver.txt
> > @@ -7,6 +7,8 @@ Required properties:
> > Optional properties:
> > - linux,rc-map-name: see rc.txt file in the same
> > directory.
> > + - linux,autosuspend-period: autosuspend delay time,
> > + the unit is milisecond.
>
> What makes this linux specific?

Good point. "linux,autosuspend-period" does not say what is being
suspended either. How about "cpuidle-suspend-period" instead?


Sean