Re: [PATCH 2/3] x86/cpu: Describe hybrid CPUs in cpuinfo_x86

From: Ricardo Neri
Date: Fri Oct 02 2020 - 17:00:33 EST


On Fri, Oct 02, 2020 at 10:34:52PM +0200, Borislav Petkov wrote:
> On Fri, Oct 02, 2020 at 01:19:30PM -0700, Ricardo Neri wrote:
> > diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> > index 35ad8480c464..0778b3ad26b3 100644
> > --- a/arch/x86/kernel/cpu/common.c
> > +++ b/arch/x86/kernel/cpu/common.c
> > @@ -932,6 +932,11 @@ void get_cpu_cap(struct cpuinfo_x86 *c)
> > c->x86_capability[CPUID_D_1_EAX] = eax;
> > }
> >
> > + if (cpu_has(c, X86_FEATURE_HYBRID_CPU)) {
> > + cpuid_count(0x0000001a, 0, &eax, &ebx, &ecx, &edx);
> > + c->x86_cpu_type = eax;
>
> c->x86_cpu_type = cpuid_eax(0x0000001a);
>
> should do too.

Thank you for the quick feedback Boris! Sure I can implement it as you
suggest.

>
> But send this patch together with the code that uses it.

Sure I can submit it along with the code using it.

What about patches 1 and 3? Should I resubmit the series with only
those?

Thanks and BR,
Ricardo