Re: [PATCH v1] i2c: npcm7xx: Support changing bus speed using debugfs.

From: Alex Qiu
Date: Thu Oct 01 2020 - 17:11:31 EST


On Thu, Oct 1, 2020 at 11:51 AM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> I see. So, there are following statements:
> - the elaboration is good but I guess needs to be added somewhere in
> form of the documentation
> - the internal schedules or so are not crucial for the upstream (it
> rather sounds like a bribing the judge)
> - the current approach, if I'm not mistaken, is using debugfs, which
> is not ABI and it's good
> - I'm not a maintainer here, but I don't like the approach
>
> Let the maintainer decide.
>
> --
> With Best Regards,
> Andy Shevchenko

Hi Andy,

That makes perfect sense. We may keep it downstream to unblock our own
work if it's not accepted upstream. Thanks for your review!

- Alex Qiu