Re: [PATCH v1] PCI: brcmstb: fix error return paths in probe()

From: Florian Fainelli
Date: Thu Oct 01 2020 - 14:51:38 EST




On 10/1/2020 8:18 AM, Jim Quinlan wrote:
Fixes two cases where we were returning without calling
clk_disable_unprepare(). Although there is a common place to go on probe()
errors (the 'fail' label), one can only jump there after executing
brcm_pcie_setup(), so we have to add clk_disable_unprepare() calls to the
two error paths.

Fixes: b98f52bc6495 ("PCI: brcmstb: Add control of rescal reset")
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Signed-off-by: Jim Quinlan <james.quinlan@xxxxxxxxxxxx>

Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
--
Florian