Re: [PATCH] x86/kvm: hide KVM options from menuconfig when KVM is not compiled

From: Vitaly Kuznetsov
Date: Thu Oct 01 2020 - 10:01:06 EST


Matteo Croce <mcroce@xxxxxxxxxxxxxxxxxxx> writes:

> From: Matteo Croce <mcroce@xxxxxxxxxxxxx>
>
> Let KVM_WERROR depend on KVM, so it doesn't show in menuconfig alone.
>
> Signed-off-by: Matteo Croce <mcroce@xxxxxxxxxxxxx>

I'd even say

Fixes: 4f337faf1c55e ("KVM: allow disabling -Werror")

> ---
> arch/x86/kvm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> index fbd5bd7a945a..f92dfd8ef10d 100644
> --- a/arch/x86/kvm/Kconfig
> +++ b/arch/x86/kvm/Kconfig
> @@ -66,6 +66,7 @@ config KVM_WERROR
> default y if X86_64 && !KASAN
> # We use the dependency on !COMPILE_TEST to not be enabled
> # blindly in allmodconfig or allyesconfig configurations
> + depends on KVM
> depends on (X86_64 && !KASAN) || !COMPILE_TEST
> depends on EXPERT
> help

Reviewed-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>

--
Vitaly