Re: [GIT PULL][PATCH v4 0/9] Update to zstd-1.4.6

From: David Sterba
Date: Thu Oct 01 2020 - 06:20:00 EST


On Wed, Sep 30, 2020 at 08:49:49PM +0000, Nick Terrell wrote:
> > On Sep 29, 2020, at 11:53 PM, Nick Terrell <nickrterrell@xxxxxxxxx> wrote:
> >
> > From: Nick Terrell <terrelln@xxxxxx>
>
> It has been brought to my attention that patch 3 hasn’t made it to patchwork,
> likely because it is too large. I’ll include a pull request in the next cover letter,
> together with the patches (if needed).

The patch 3/9 saved to a file is 1.6M, over 35000 lines, the diffstat
says:

66 files changed, 24268 insertions(+), 12889 deletions(-)

Seriously, this is wrong in so many ways. There's the rationale for
one-time change etc, but the actual result is beyond what I would accept
and would not encourage anyone to merge as-is.