Re: [PATCH] tty: serial: mvebu-uart: Remove unused variable 'ret'

From: Jiri Slaby
Date: Wed Sep 30 2020 - 04:22:00 EST


On 30. 09. 20, 10:14, Pujin Shi wrote:
> 'ret' variable is now defined but not used in mvebu_uart_probe(),
> causing this warning:
>
> drivers/tty/serial/mvebu-uart.c: In function ‘mvebu_uart_probe’:
> drivers/tty/serial/mvebu-uart.c:806:6: warning: unused variable ‘ret’ [-Wunused-variable]
>
> Signed-off-by: Pujin Shi <shipujin.t@xxxxxxxxx>

Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>

> ---
> drivers/tty/serial/mvebu-uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c
> index 7443c0506eb4..118b29912289 100644
> --- a/drivers/tty/serial/mvebu-uart.c
> +++ b/drivers/tty/serial/mvebu-uart.c
> @@ -803,7 +803,7 @@ static int mvebu_uart_probe(struct platform_device *pdev)
> &pdev->dev);
> struct uart_port *port;
> struct mvebu_uart *mvuart;
> - int ret, id, irq;
> + int id, irq;
>
> if (!reg) {
> dev_err(&pdev->dev, "no registers defined\n");
>

thanks,
--
js
suse labs