Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors

From: Eli Cohen
Date: Tue Sep 29 2020 - 02:01:55 EST


On Fri, Sep 25, 2020 at 06:20:45AM -0400, Michael S. Tsirkin wrote:
> > >
> > > Hmm other drivers select VHOST_IOTLB, why not do the same?
> >
> > I can't see another driver doing that.
>
> Well grep VHOST_IOTLB and you will see some examples.

$ git grep -wn VHOST_IOTLB
drivers/vhost/Kconfig:2:config VHOST_IOTLB
drivers/vhost/Kconfig:11: select VHOST_IOTLB
drivers/vhost/Kconfig:18: select VHOST_IOTLB

What am I missing here?

> > Perhaps I can set dependency on
> > VHOST which by itself depends on VHOST_IOTLB?
>
> VHOST is processing virtio in the kernel. You don't really need that
> for mlx, do you?
>
> > >
> > >
> > > > > help
> > > > > Support library for Mellanox VDPA drivers. Provides code that is
> > > > >
> > >
>