Re: [PATCH 2/3] net/mlx5e: Clean up error handling in mlx5e_alloc_flow()

From: Leon Romanovsky
Date: Mon Sep 28 2020 - 03:39:56 EST


On Sun, Sep 27, 2020 at 12:32:52PM +0100, Alex Dewar wrote:
> The variable flow is used after being allocated but before being
> null-checked, which will cause a null pointer dereference if the
> allocation failed. Fix this and tidy up the error-checking logic in this
> function.
>
> Addresses-Coverity: CID 1497154: Null pointer dereferences (REVERSE_INULL)
> Signed-off-by: Alex Dewar <alex.dewar90@xxxxxxxxx>
> ---
> .../net/ethernet/mellanox/mlx5/core/en_tc.c | 20 ++++++++++---------
> 1 file changed, 11 insertions(+), 9 deletions(-)
>

Thanks, but Gustavo already sent a fix.
https://lore.kernel.org/lkml/20200925164913.GA18472@embeddedor