Re: [RFC PATCH v2] tools/x86: add kcpuid tool to show raw CPU features

From: Borislav Petkov
Date: Fri Sep 25 2020 - 16:58:01 EST


On Fri, Sep 25, 2020 at 04:40:47PM -0400, Arvind Sankar wrote:
> They're not the same, but aren't there going to be quite a few common
> flags between the definitions in cpufeatures.h and the definitions in
> cpuid.txt? If they're both living in the kernel repo, it would be nice
> for them to not duplicate what's common between them, no?

You will generate cpuid.txt exactly once and shortly after cpufeatures.h
will already be ancient in comparison to it. So there would be no point
to share.

Also, have a look at which leafs are in cpufeatures.h, which of those
leafs are synthetic and how many leafs are in an actual CPUID hw
implementation.

Then, some of the bits in cpufeatures.h are not present while the leafs
in CPUID have them for the above reason.

And so on...

> This shouldn't affect how easy it is to update, I think. The kernel
> build will use whatever version is in the source tree, the tool will use
> whatever version is installed under /usr/share, so the latter can be
> updated without needing a new kernel.

And I believe that keeping those apart because there are differences,
would cause more confusion vs having the two things completely separate.

So I actually think that sharing between the two is not even worth the
effort.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette