Re: [PATCH] net: ethernet: cavium: octeon_mgmt: use phy_start and phy_stop

From: Andrew Lunn
Date: Fri Sep 25 2020 - 12:30:18 EST


On Fri, Sep 25, 2020 at 03:44:39PM +0300, Ivan Khoronzhuk wrote:
> To start also "phy state machine", with UP state as it should be,
> the phy_start() has to be used, in another case machine even is not
> triggered. After this change negotiation is supposed to be triggered
> by SM workqueue.
>
> It's not correct usage, but it appears after the following patch,
> so add it as a fix.
>
> Fixes: 74a992b3598a ("net: phy: add phy_check_link_status")
> Signed-off-by: Ivan Khoronzhuk <ikhoronz@xxxxxxxxx>
> ---
>
> Based on net/master

Hi Ivan

In the future, please make the patch subject [PATCH net] to make it
clear which tree it is for.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew