Re: [PATCH 1/3] slimbus: core: check get_addr before removing laddr ida

[Srinivas Kandagatla]

On 25/09/2020 13:41, Greg KH wrote:
> On Fri, Sep 25, 2020 at 10:55:18AM +0100, Srinivas Kandagatla wrote:
> > logical address can be either assigned by the SLIMBus controller or the core.
> > Core uses IDA in cases where get_addr callback is not provided by the
> > controller.
> > Core already has this check while allocating IDR, however during absence
> > reporting this is not checked. This patch fixes this issue.
> >
> > Fixes: 46a2bb5a7f7ea("slimbus: core: Add slim controllers support")
>
> Nit, you need a ' ' before the '(' character...
Not sure how I missed that :-)

> Also, you don't need all of those characters, you have 1 more than
> necessary :)
>
> I'll go fix it up.
Thankyou very much for fixing this up!

--srini
> greg k-h