Re: [PATCH v38 17/24] x86/sgx: ptrace() support for the SGX driver'

From: Borislav Petkov
Date: Fri Sep 25 2020 - 03:51:15 EST


On Thu, Sep 24, 2020 at 11:38:59PM +0300, Jarkko Sakkinen wrote:
> I assume this is a rethorical question

Of course - our text should not be write-only.

> and I notice what I suggested
> looks as bad as my earlier commit message :-)
>
> So, I gave it some thought that and decided to "open code" the paragraph
> as
>
> "Add sgx_vma_access() function that implements 'access' virtual function
> of struct vm_operations_struct. Use formentioned leaf instructions to

"aforementioned"

> achieve read and write primitives for the enclave memory."

I'd say "to provide read and write access to enclave memory."

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette