Re: [PATCH v2 1/3] ARM: tegra: Add device-tree for Ouya

From: Dmitry Osipenko
Date: Thu Sep 24 2020 - 20:13:08 EST


...
> +/ {
> + model = "Ouya Game Console";
> + compatible = "ouya,ouya", "nvidia,tegra30";
> +
> + aliases {
> + rtc0 = &pmic;
> + rtc1 = "/rtc@7000e000";
> + serial0 = &uartd; /* Debug Port */
> + serial1 = &uartc; /* Bluetooth */
> + mmc0 = &sdmmc4; /* eMMC */
> + mmc1 = &sdmmc3; /* WiFi */

Thierry may want to sort these aliases in alphabet order.

> + };

...
> + pmic: pmic@2d {
> + compatible = "ti,tps65911";
> + reg = <0x2d>;
> +
> + interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
> + #interrupt-cells = <2>;
> + interrupt-controller;
> +
> + ti,system-power-controller;

Are the ti,sleep-keep-ck32k and other properties not needed for Ouya
like they are needed for Nexus 7?

...
> + sdmmc3: mmc@78000400 {
> + status = "okay";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + bus-width = <4>;
> + non-removable;

Recently I added assigned-clocks here for Nexus7/A500 DTs in order to
get true 50MHz for the WiFi SDIO.

> + mmc-pwrseq = <&wifi_pwrseq>;
> + vmmc-supply = <&sdmmc_3v3_reg>;
> + vqmmc-supply = <&vdd_1v8>;