Re: [PATCH v38 20/24] x86/traps: Attempt to fixup exceptions in vDSO before signaling

From: Borislav Petkov
Date: Thu Sep 24 2020 - 12:31:37 EST


On Tue, Sep 15, 2020 at 02:28:38PM +0300, Jarkko Sakkinen wrote:
> diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
> index 9e5ec861aba0..ebe290a68c36 100644
> --- a/arch/x86/mm/fault.c
> +++ b/arch/x86/mm/fault.c
> @@ -30,6 +30,7 @@
> #include <asm/cpu_entry_area.h> /* exception stack */
> #include <asm/pgtable_areas.h> /* VMALLOC_START, ... */
> #include <asm/kvm_para.h> /* kvm_handle_async_pf */
> +#include <asm/vdso.h> /* fixup_vdso_exception() */
>
> #define CREATE_TRACE_POINTS
> #include <asm/trace/exceptions.h>
> @@ -775,6 +776,10 @@ __bad_area_nosemaphore(struct pt_regs *regs, unsigned long error_code,
>
> sanitize_error_code(address, &error_code);
>
> + if (fixup_vdso_exception(regs, X86_TRAP_PF, error_code,
> + address))

No need to break that line.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette