Re: [PATCH 5/9] gpio: mockup: use pr_fmt()

From: Joe Perches
Date: Thu Sep 24 2020 - 12:05:05 EST


On Thu, 2020-09-24 at 13:38 +0200, Bartosz Golaszewski wrote:
> We don't need a custom logging helper. Let's use the standard pr_fmt()
> macro which allows us to use all pr_*() routines with custom format.
[]
> diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
[]
> @@ -577,7 +577,7 @@ static int __init gpio_mockup_init(void)
>
> pdev = platform_device_register_full(&pdevinfo);
> if (IS_ERR(pdev)) {
> - gpio_mockup_err("error registering device");
> + pr_err("error registering device");

You could add the missing newline at the same time.