Re: [RFC PATCH 8/9] surface_aggregator: Add DebugFS interface

From: Arnd Bergmann
Date: Thu Sep 24 2020 - 03:41:50 EST


On Thu, Sep 24, 2020 at 12:23 AM Maximilian Luz <luzmaximilian@xxxxxxxxx> wrote:
> On 9/23/20 8:51 PM, Arnd Bergmann wrote:
> > On Wed, Sep 23, 2020 at 8:29 PM Maximilian Luz <luzmaximilian@xxxxxxxxx> wrote:
> >> On 9/23/20 6:48 PM, Arnd Bergmann wrote:
> >
> > The version I showed avoids the pointers and is compatible with
> > 32-bit user space.
>
> I'm not completely convinced yet that the read/write approach is the way
> I want to do it, especially with Greg suggesting a misc device, but I'll
> keep your solution in mind.

In case of a character device, I'd go with an ioctl to keep it extensible.

The read/write based interface is what I'd use in debugfs.

Arnd