Re: [PATCH] fork: Use helper function mapping_allow_writable() in dup_mmap()

[linmiaohe]

Christian Brauner <christian.brauner@xxxxxxxxxx> wrote:
> On Sun, Sep 13, 2020 at 05:24:15AM -0400, Miaohe Lin wrote:
>> Use helper function mapping_allow_writable() to atomic_inc i_mmap_writable.
>> 
>> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
>> ---
>
>Hey Miaohe,
>
>Thanks for the patch!
>Per se there's nothing against using a proper helper when it exists.
>But it has already been pointed out that this needs a proper commit message with more rationale. But I'm otherwise happy to take this.
>

Many thanks for your reply.
Eric have kindly pointed this out. I think I should provide a proper commit message with more rationale in v2.
Thanks again.

>Thanks!
>Christian