Re: [PATCH 2/3] virtio_input: Constify id_table

From: David Hildenbrand
Date: Mon Sep 14 2020 - 03:47:37 EST


On 11.09.20 22:35, Rikard Falkeborn wrote:
> id_table is not modified, so make it const to allow the compiler to put
> it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@xxxxxxxxx>
> ---
> drivers/virtio/virtio_input.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c
> index 877b2ea3ed05..f1f6208edcf5 100644
> --- a/drivers/virtio/virtio_input.c
> +++ b/drivers/virtio/virtio_input.c
> @@ -363,7 +363,7 @@ static int virtinput_restore(struct virtio_device *vdev)
> static unsigned int features[] = {
> /* none */
> };
> -static struct virtio_device_id id_table[] = {
> +static const struct virtio_device_id id_table[] = {
> { VIRTIO_ID_INPUT, VIRTIO_DEV_ANY_ID },
> { 0 },
> };
>

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Thanks,

David / dhildenb