Re: [PATCH] bus: arm-integrator-lm: Add of_node_put() before return statement
From: Linus Walleij
Date: Sat Sep 12 2020 - 06:10:41 EST
On Sat, Aug 29, 2020 at 7:42 PM Sumera Priyadarsini
<sylphrenadin@xxxxxxxxx> wrote:
> Every iteration of for_each_available_child_of_node() decrements
> the reference count of the previous node, however when control is
> transferred from the middle of the loop, as in the case of a return
> or break or goto, there is no decrement thus ultimately resulting in
> a memory leak.
>
> Fix a potential memory leak in arm-integrator-lm.c by inserting
> of_node_put() before a return statement.
>
> Issue found with Coccinelle.
>
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@xxxxxxxxx>
Patch applied.
Yours,
Linus Walleij