Re: [PATCH v8 17/18] nitro_enclaves: Add overview documentation

From: Greg KH
Date: Fri Sep 11 2020 - 12:39:07 EST


On Fri, Sep 11, 2020 at 05:56:10PM +0300, Paraschiv, Andra-Irina wrote:
>
>
> On 07/09/2020 18:13, Paraschiv, Andra-Irina wrote:
> >
> >
> > On 07/09/2020 17:08, Greg KH wrote:
> > > On Mon, Sep 07, 2020 at 04:43:11PM +0300, Paraschiv, Andra-Irina wrote:
> > > >
> > > > On 07/09/2020 12:01, Greg KH wrote:
> > > > > On Fri, Sep 04, 2020 at 08:37:17PM +0300, Andra Paraschiv wrote:
> > > > > > Signed-off-by: Andra Paraschiv <andraprs@xxxxxxxxxx>
> > > > > > Reviewed-by: Alexander Graf <graf@xxxxxxxxxx>
> > > > > > ---
> > > > > > Changelog
> > > > > >
> > > > > > v7 -> v8
> > > > > >
> > > > > > * Add info about the primary / parent VM CID value.
> > > > > > * Update reference link for huge pages.
> > > > > > * Add reference link for the x86 boot protocol.
> > > > > > * Add license mention and update doc title / chapter formatting.
> > > > > >
> > > > > > v6 -> v7
> > > > > >
> > > > > > * No changes.
> > > > > >
> > > > > > v5 -> v6
> > > > > >
> > > > > > * No changes.
> > > > > >
> > > > > > v4 -> v5
> > > > > >
> > > > > > * No changes.
> > > > > >
> > > > > > v3 -> v4
> > > > > >
> > > > > > * Update doc type from .txt to .rst.
> > > > > > * Update documentation based on the changes from v4.
> > > > > >
> > > > > > v2 -> v3
> > > > > >
> > > > > > * No changes.
> > > > > >
> > > > > > v1 -> v2
> > > > > >
> > > > > > * New in v2.
> > > > > > ---
> > > > > >    Documentation/nitro_enclaves/ne_overview.rst | 95
> > > > > > ++++++++++++++++++++
> > > > > >    1 file changed, 95 insertions(+)
> > > > > >    create mode 100644 Documentation/nitro_enclaves/ne_overview.rst
> > > > > A whole new subdir, for a single driver, and not tied into the kernel
> > > > > documentation build process at all?  Not good :(
> > > > >
> > > > Would the "virt" directory be a better option for this doc file?
> > > Yes.
> >
> > Alright, I'll update the doc file location, the index file and the
> > MAINTAINERS entry to reflect the new doc file location.
> >
>
> I sent out a new revision that includes the updates based on your feedback.
> Thanks for review.
>
> To be aware of this beforehand, what would be the further necessary steps
> (e.g. linux-next branch, additional review and / or sanity checks) to
> consider for targeting the next merge window?

If all looks good, I can just suck it into my char-misc branch to get it
into 5.10-rc1. I'll look at the series next week, thanks.

thanks,

greg k-h