Re: [PATCH v1] x86/defconfigs: Unbreak 32-bit defconfig builds

From: Andy Shevchenko
Date: Tue Sep 08 2020 - 14:45:59 EST


On Tue, Sep 8, 2020 at 8:53 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> On 9/8/20 5:13 AM, Ingo Molnar wrote:
> > * Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >
> >> After the commit 1d0e12fd3a84 ("x86/defconfigs: Refresh defconfig files")
> >> 32-bit builds using defconfig become broken because on x86_64 build host
> >> with no ARCH provided the default behaviour is to assume 64-bit independently
> >> on the configuration file name. The crucial part is CONFIG_64BIT option
> >> that used to be explicit. Let restore the latter option in order to unbreak
> >> 32-bit builds.
> >
> > So exactly which build method broke due to this? The typical way to do a defconfig build is:
> >
> > make ARCH=i386 defconfig
> >
> > which still works fine AFAICS.
> >
> > Thanks,
> >
> > Ingo
> >
>
> Here is a previous patch from someone else:
>
> https://lore.kernel.org/lkml/20200810155943.2583275-1-daniel.diaz@xxxxxxxxxx/

Thanks for pointing out. Whatever Ingo prefers (though personally I
think the other one requires more work on the shrinking commit
message).

--
With Best Regards,
Andy Shevchenko