Re: [PATCH v3 06/15] MIPS: generic: Allow boards to set system type

[Philippe Mathieu-Daudé]

On Sun, Sep 6, 2020 at 9:31 PM Paul Cercueil <paul@xxxxxxxxxxxxxxx> wrote:
>
> Check for the (already existing) "system_type" variable in the
> get_system_type() function. If non-NULL, return it as the system type.

Nitpick: It is not already "existing", simply declared in asm/bootinfo.h.

>
> Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> ---
>
> Notes:
>     v2: Instead of adding a .get_system_type callback to the mips_machine
>         struct, the boards now simply override the "system_type" variable
>         when they want to set a custom one.
>
>     v3: No change
>
>  arch/mips/generic/proc.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/arch/mips/generic/proc.c b/arch/mips/generic/proc.c
> index 4c992809cc3f..cce2fde219a3 100644
> --- a/arch/mips/generic/proc.c
> +++ b/arch/mips/generic/proc.c
> @@ -8,11 +8,16 @@
>
>  #include <asm/bootinfo.h>
>
> +char *system_type;
> +
>  const char *get_system_type(void)
>  {
>         const char *str;
>         int err;
>
> +       if (system_type)
> +               return system_type;
> +
>         err = of_property_read_string(of_root, "model", &str);
>         if (!err)
>                 return str;
> --
> 2.28.0
>