Re: [PATCH net-next] net: xilinx: remove redundant null check before clk_disable_unprepare()

From: Jakub Kicinski
Date: Mon Sep 07 2020 - 16:39:27 EST


On Mon, 7 Sep 2020 13:14:05 +0000 Radhey Shyam Pandey wrote:
> > From: Zhang Changzhong <zhangchangzhong@xxxxxxxxxx>
> > Sent: Monday, September 7, 2020 6:32 PM
> > To: Radhey Shyam Pandey <radheys@xxxxxxxxxx>; davem@xxxxxxxxxxxxx;
> > kuba@xxxxxxxxxx; Michal Simek <michals@xxxxxxxxxx>
> > Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> > Subject: [PATCH net-next] net: xilinx: remove redundant null check before
> > clk_disable_unprepare()
> >
> > Because clk_prepare_enable() and clk_disable_unprepare() already checked
> > NULL clock parameter, so the additional checks are unnecessary, just
> > remove them.
> >
> > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > Signed-off-by: Zhang Changzhong <zhangchangzhong@xxxxxxxxxx>
>
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxxxxx>

Applied, thanks!