Re: [PATCH] misc: fastrpc: add ioctl for attaching to sensors pd

[Jonathan Marek]

On 9/7/20 10:01 AM, Srinivas Kandagatla wrote:
> On 07/09/2020 14:47, Jonathan Marek wrote:
> > On 9/7/20 8:36 AM, Srinivas Kandagatla wrote:
> > > On 01/09/2020 01:32, Jonathan Marek wrote:
> > > > -#define FASTRPC_IOCTL_MMAP              _IOWR('R', 6, struct 
> > > > fastrpc_req_mmap)
> > > > -#define FASTRPC_IOCTL_MUNMAP            _IOWR('R', 7, struct 
> > > > fastrpc_req_munmap)
> > > > +#define FASTRPC_IOCTL_MMAP        _IOWR('R', 6, struct 
> > > > fastrpc_req_mmap)
> > > > +#define FASTRPC_IOCTL_MUNMAP        _IOWR('R', 7, struct 
> > > > fastrpc_req_munmap)
> > >
> > > Looks like changes that do not belong to this patch!
> > >
> > > I wanted to try this patch on SM8250.
> > > How do you test attaching fastrpc to sensor core?, I mean which 
> > > userspace lib/tool do you use?
> > >
> > > --srini
> >
> > I pushed my sdsprpcd implementation to github, which is responsible 
> > for initializing the sensors, and uses this ioctl:
> >
> > https://github.com/flto/fastrpc
>
> Thanks!, I can take a look and see if I can try it out with linaro 
> fastrpc library!

You don't need linaro fastrpc library to try it, everything you need is 
in that repo.

> > Note: it uses my own WIP fastrpc "library" instead of the one from 
> > linaro, I also have other related code, like a sensor client, and 
> > cDSP/aDSP compute examples, but need to confirm that I can share them
> >
> > Also, the corresponding dts patch I sent has a problem, the label = 
> > "dsps"; should be label = "sdsp"; (copied the "dsps" from downstream, 
> > but upstream expects "sdsp"), will send a v2 later today.
> Also the dts patch will fail to apply as it is, as it seems me that you 
> have based the patch after adding audio dts patch!

Thanks for pointing it out, will make sure the v2 applies cleanly 
without audio dts patches applied.

> --srini
> > > > +#define FASTRPC_IOCTL_INIT_ATTACH_SNS    _IO('R', 8)