Re: [PATCH v2] gpio: siox: explicitly support only threaded irqs

From: Uwe Kleine-König
Date: Mon Sep 07 2020 - 12:15:55 EST


Hello Ahmad,

On Mon, Sep 07, 2020 at 05:31:35PM +0200, Ahmad Fatoum wrote:
> The gpio-siox driver uses handle_nested_irq() to implement its
> interrupt support. This is only capable of handling threaded irq
> actions. For a hardirq action it triggers a NULL pointer oops.
> (It calls action->thread_fn which is NULL then.)
>
> Prevent registration of a hardirq action by setting
> gpio_irq_chip::threaded to true.

cool commit log :-)

> Cc: u.kleine-koenig@xxxxxxxxxxxxxx
> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>

Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Thanks for picking this up.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature