Re: [PATCH] iomap: Fix direct I/O write consistency check

From: Christoph Hellwig
Date: Mon Sep 07 2020 - 03:07:15 EST


On Thu, Sep 03, 2020 at 06:56:32PM +0200, Andreas Gruenbacher wrote:
> When a direct I/O write falls back to buffered I/O entirely, dio->size
> will be 0 in iomap_dio_complete. Function invalidate_inode_pages2_range
> will try to invalidate the rest of the address space. If there are any
> dirty pages in that range, the write will fail and a "Page cache
> invalidation failure on direct I/O" error will be logged.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>