Re: [linux-next PATCH v4] drivers/virt/fsl_hypervisor: Fix error handling path

[John Hubbard]

On 9/4/20 6:16 PM, Souptick Joarder wrote:
> Hi Andrew,
>
> On Wed, Sep 2, 2020 at 3:00 AM John Hubbard <jhubbard@xxxxxxxxxx> wrote:
> > On 9/1/20 2:21 PM, Souptick Joarder wrote:
> > > First, when memory allocation for sg_list_unaligned failed, there
> > > is a bug of calling put_pages() as we haven't pinned any pages.
> > >
> > > Second, if get_user_pages_fast() failed we should unpin num_pinned
> > > pages.
> > >
> > > This will address both.
> > >
> > > As part of these changes, minor update in documentation.
> > >
> > > Fixes: 6db7199407ca ("drivers/virt: introduce Freescale hypervisor
> > > management driver")
> > > Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>
> > > Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > > Reviewed-by: John Hubbard <jhubbard@xxxxxxxxxx>
> > > ---
> >
> > This looks good to me.
>
> Can you please take this patch through the mm tree ?

Is there a problem with sending it through it's normal tree? It would probably
get better testing coverage there.


thanks,
--
John Hubbard
NVIDIA