Re: [PATCH v3 02/10] objtool: Make sync-check consider the target architecture

From: Josh Poimboeuf
Date: Fri Sep 04 2020 - 14:22:40 EST


On Fri, Sep 04, 2020 at 04:30:20PM +0100, Julien Thierry wrote:
> Do not take into account outdated headers unrelated to the build of the
> current architecture.
>
> Reviewed-by: Miroslav Benes <mbenes@xxxxxxx>
> Signed-off-by: Julien Thierry <jthierry@xxxxxxxxxx>
> ---
> tools/objtool/Makefile | 2 +-
> tools/objtool/sync-check.sh | 4 ++++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile
> index 33d1e3ca8efd..20df5541ca43 100644
> --- a/tools/objtool/Makefile
> +++ b/tools/objtool/Makefile
> @@ -64,7 +64,7 @@ export srctree OUTPUT CFLAGS SRCARCH AWK
> include $(srctree)/tools/build/Makefile.include
>
> $(OBJTOOL_IN): fixdep FORCE
> - @$(CONFIG_SHELL) ./sync-check.sh
> + @$(CONFIG_SHELL) ./sync-check.sh $(SRCARCH)
> @$(MAKE) $(build)=objtool

SRCARCH is already exported by the Makefile, so should sync-check.sh
just check $SRCARCH directly (and error out if it doesn't exist)?

--
Josh