Re: [PATCH] crypto: Mark tfm buffer as non leak.

From: Herbert Xu
Date: Fri Sep 04 2020 - 03:17:19 EST


Peter Enderborg <peter.enderborg@xxxxxxxx> wrote:
>
> This is caused by tfm = (struct crypto_tfm *)(mem + tfmsize);
> that is keept instead of the allocated buffer in mem.
> Reference counting is done on alg.

I don't understand why this is necessary. We end up returning
mem in crypto_create_tfm_node and that is the primary means of
getting to the object.

The tfm pointer is just an internal thing. So why do we have
to mark mem as not a leak?

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt