Re: [PATCH RESEND] smsc9420: switch from 'pci_' to 'dma_' API

From: David Miller
Date: Thu Sep 03 2020 - 19:54:35 EST


From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Date: Thu, 3 Sep 2020 22:10:55 +0200

> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
>
> When memory is allocated in 'smsc9420_probe()', GFP_KERNEL can be used
> because it is a probe function and no lock is acquired.
>
> While at it, rewrite the size passed to 'dma_alloc_coherent()' the same way
> as the one passed to 'dma_free_coherent()'. This form is less verbose:
> sizeof(struct smsc9420_dma_desc) * RX_RING_SIZE +
> sizeof(struct smsc9420_dma_desc) * TX_RING_SIZE,
> vs
> sizeof(struct smsc9420_dma_desc) * (RX_RING_SIZE + TX_RING_SIZE)
...
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Applied.