Re: [PATCH 08/29] dma-buf: Avoid comma separated statements

From: Sumit Semwal
Date: Thu Sep 03 2020 - 11:11:58 EST


Hello Joe,

On Wed, 26 Aug 2020 at 20:38, Christian König <christian.koenig@xxxxxxx> wrote:
>
> Am 25.08.20 um 06:56 schrieb Joe Perches:
> > Use semicolons and braces.
> >
> > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
>
> Acked-by: Christian König <christian.koenig@xxxxxxx>
FWIW,
Acked-by: Sumit Semwal <sumit.semwal@xxxxxxxxxx>

>
> > ---
> > drivers/dma-buf/st-dma-fence.c | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c
> > index e593064341c8..c8a12d7ad71a 100644
> > --- a/drivers/dma-buf/st-dma-fence.c
> > +++ b/drivers/dma-buf/st-dma-fence.c
> > @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg)
> > dma_fence_signal(f1);
> >
> > smp_store_mb(cb.seen, false);
> > - if (!f2 || dma_fence_add_callback(f2, &cb.cb, simple_callback))
> > - miss++, cb.seen = true;
> > + if (!f2 ||
> > + dma_fence_add_callback(f2, &cb.cb, simple_callback)) {
> > + miss++;
> > + cb.seen = true;
> > + }
> >
> > if (!t->before)
> > dma_fence_signal(f1);
>