Re: [PATCH v7 2/5] perf/jevents: Add new structure to pass json fields.

[John Garry]

On 02/09/2020 17:04, Kajol Jain wrote:
> This patch adds new structure called 'json_event' inside jevents.h
> file to improve the callback prototype inside jevent files.
> Initially, whenever user want to add new field, they need to update
> in all function callback which make it more and more complex with
> increased number of parmeters.
> With this change, we just need to add it in new structure 'json_event'.
>
> Signed-off-by: Kajol Jain <kjain@xxxxxxxxxxxxx>
> Reviewed-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

Reviewed-by: John Garry <john.garry@xxxxxxxxxx>

> +static int json_events

Adding 'static' should have really been in the previous patch ...