Re: [PATCH 5/6] parport: rework procfs handlers to take advantage of the new buffer

From: Christoph Hellwig
Date: Tue Sep 01 2020 - 11:16:18 EST


On Thu, Aug 13, 2020 at 05:04:10PM -0400, Josef Bacik wrote:
> The buffer coming from higher up the stack has an extra byte to handle
> the NULL terminator in the string. Instead of using a temporary buffer
> to sprintf into and then copying into the buffer, just scnprintf
> directly into the buffer and update lenp as appropriate.
>
> Signed-off-by: Josef Bacik <josef@xxxxxxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>