Re: [PATCH v2] mmc: mmc_spi: Allow the driver to be built when CONFIG_HAS_DMA is unset

From: Christoph Hellwig
Date: Tue Sep 01 2020 - 11:07:27 EST


On Tue, Sep 01, 2020 at 05:04:38PM +0200, Ulf Hansson wrote:
> +#ifdef CONFIG_HAS_DMA
> +static int mmc_spi_dma_alloc(struct mmc_spi_host *host)
> +{
> + struct spi_device *spi = host->spi;
> + struct device *dev;
> +
> + if (!spi->master->dev.parent->dma_mask)
> + return 0;

I still don't think this makes sense, as the dma_mask should always
be non-NULL here.