Re: [PATCH 4/5] ARM: dts: Aspeed: Tacoma: Add IBM Operation Panel I2C device

From: Wolfram Sang
Date: Tue Sep 01 2020 - 02:11:48 EST



> > + ibm-panel@62 {
> > + compatible = "ibm,op-panel";
> > + reg = <0x40000062>; /* I2C_OWN_SLAVE_ADDRESS */
>
> Other users of SLAVE_ADDRESS have included <dt-bindings/i2c/i2c.h> and
> written the reg as follows:
>
> reg = <(I2C_OWN_SLAVE_ADDRESS | 0x62)>
>
> Which obviously has the same result. I'll leave it up to you.

The latter, please.

Attachment: signature.asc
Description: PGP signature