Re: [PATCH 2/2] mm/migrate: preserve soft dirty in remove_migration_pte()

From: Christoph Hellwig
Date: Tue Sep 01 2020 - 01:20:29 EST


On Mon, Aug 31, 2020 at 02:22:22PM -0700, Ralph Campbell wrote:
> The code to remove a migration PTE and replace it with a device private
> PTE was not copying the soft dirty bit from the migration entry.
> This could lead to page contents not being marked dirty when faulting
> the page back from device private memory.
>
> Signed-off-by: Ralph Campbell <rcampbell@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>