Re: [PATCH] SELinux: Measure state and hash of policy using IMA

From: Lakshmi Ramasubramanian
Date: Mon Aug 31 2020 - 12:39:13 EST


On 8/31/20 7:47 AM, Stephen Smalley wrote:



Could you please let me know when the current set of changes in SELinux
next branch would be completed and be ready to take new changes?

I mean, roughly - would it be a month from now or you expect that to
take longer?

I can't speak for Paul but I would expect it to be sooner rather than
later. Ondrej has some follow ups on top of my policy rcu conversion
but then it should be good to go.

I think the major changes are now merged although there are still a
couple of changes coming from Ondrej that could affect your code. For
your purposes, the important things to note are:

1) The mutex has moved from selinux_fs_info to selinux_state and is
now named policy_mutex. You will need to take it around your call to
security_read_policy_kernel().

2) security_policydb_len() was removed and security_read_policy() just
directly reads the policydb len. You can do the same from your
security_read_policy_kernel() variant.

3) Ondrej has a pending change to move the policycap[] array from
selinux_state to selinux_policy so that it can be atomically updated
with the policy.

4) Ondrej has a pending change to eliminate the separate initialized
boolean from selinux_state and just test whether selinux_state.policy
is non-NULL but as long as you are using selinux_initialized() to
test, your code should be unaffected.


Thanks a lot for the update Stephen.

I will start updating the IMA measurement changes in selinux next branch. Will post the patches this week.

-lakshmi