Re: [PATCH 3/4] kselftests/arm64: add PAuth test for whether exec() changes keys

[Amit Kachhap]

On 8/28/20 6:46 PM, Boyan Karatotev wrote:
> Kernel documentation states that it will change PAuth keys on exec() calls.
>
> Verify that all keys are correctly switched to new ones.
>
> Cc: Shuah Khan <shuah@xxxxxxxxxx>
> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> Cc: Will Deacon <will@xxxxxxxxxx>
> Signed-off-by: Boyan Karatotev <boyan.karatotev@xxxxxxx>

The changes look fine so,
Reviewed-by: Amit Daniel Kachhap <amit.kachhap@xxxxxxx>

> ---
>   tools/testing/selftests/arm64/pauth/Makefile  |   4 +
>   .../selftests/arm64/pauth/exec_target.c       |  35 +++++
>   tools/testing/selftests/arm64/pauth/helper.h  |  10 ++
>   tools/testing/selftests/arm64/pauth/pac.c     | 148 ++++++++++++++++++
>   4 files changed, 197 insertions(+)
>   create mode 100644 tools/testing/selftests/arm64/pauth/exec_target.c
>
> diff --git a/tools/testing/selftests/arm64/pauth/Makefile b/tools/testing/selftests/arm64/pauth/Makefile
> index a017d1c8dd58..2e237b21ccf6 100644
> --- a/tools/testing/selftests/arm64/pauth/Makefile
> +++ b/tools/testing/selftests/arm64/pauth/Makefile
> @@ -5,6 +5,7 @@ CFLAGS += -mbranch-protection=pac-ret
>