Re: [PATCH] iio: dac: ad5593r: Dynamically set AD5593R channel modes

[Andy Shevchenko]

On Mon, Aug 24, 2020 at 8:54 AM William Sung
<william.sung@xxxxxxxxxxxxxxxx> wrote:
>
> To use ad5593r more flexibly, we use the module parameter to setting the
> channel modes dynamically whenever the module probe up.

> Users can pass
> the channel modes to the module parameter for allocating the
> functionality of channels as desired.

NAK. We have a sysfs interface.

> For example:
> * Use in the kernel command line:
> Users can add the module parameter in the kernel command line such as
>
>     "ad5593r.ch_mode_cmdline=88001122"
>
> "88001122" means the channel mode setting for each channel. The most
> left side indicates the mode of channel 7, and the most right side
> indicates the mode of channel 0.
>
> * Use when manually probe the module:
> Similar to the kernel command line usage, users can enter
>
>     "modprobe ad5593r ch_mode_probe=88001122"
>
> to start the ad5593r module with the desired channel mode setting.

Again NAK, this basically should come from Device Tree or ACPI.

-- 
With Best Regards,
Andy Shevchenko