Re: [PATCH v2 3/9] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM

From: Sameer Pujar
Date: Sat Aug 29 2020 - 06:56:23 EST


Hi Morimoto-san,

Sorry for the delayed reply as I was on sick leave.
Sure. BTW, there are more such candidates which require 'lock' version
of these helpers.
For example: soc_find_component(), snd_soc_add/remove_pcm_runtime()
and snd_soc_register_dai().
soc_find_component() is static function, no need to care about mutex.
other functions are indeed exported function, but is used from
topology.c which is calling it under mutex.


I was just thinking if we need to future proof these functions. As you mentioned, currently these have limited usage (in topology.c) and should just be fine to address snd_soc_find_dai() for now.

Thanks,
Sameer.