Re: [PATCH v2] netlabel: remove unused param from audit_log_format()

From: David Miller
Date: Fri Aug 28 2020 - 12:09:17 EST


From: Alex Dewar <alex.dewar90@xxxxxxxxx>
Date: Fri, 28 Aug 2020 14:55:23 +0100

> Commit d3b990b7f327 ("netlabel: fix problems with mapping removal")
> added a check to return an error if ret_val != 0, before ret_val is
> later used in a log message. Now it will unconditionally print "...
> res=1". So just drop the check.
>
> Addresses-Coverity: ("Dead code")
> Fixes: d3b990b7f327 ("netlabel: fix problems with mapping removal")
> Signed-off-by: Alex Dewar <alex.dewar90@xxxxxxxxx>
> ---
> v2: Still print the res field, because it's useful (Paul)

Applied to net-next, thank you.