Re: [PATCH v2 2/3] dyndbg: refine export, rename to dynamic_debug_exec_queries()

From: Greg KH
Date: Fri Aug 28 2020 - 06:30:31 EST


On Tue, Aug 25, 2020 at 11:33:38AM -0600, Jim Cromie wrote:
> commit 59cf47e7df31 dyndbg: export ddebug_exec_queries
> left a few configs broken, fix them with ifdef stub-fns.

Please use the standard way of printing commit ids, it's in the
submitting patches document.

>
> Rename the export to dynamic_debug_exec_queries(). This is a more
> canonical function name, instead of exposing the 'ddebug' internal
> name prefix. Do this now, before export hits v5.9.0
>
> Implement as new function wrapping ddebug_exec_queries(now static
> again), which copies the query-string, preserving ddebug_exec_queries'
> in-place parsing, while allowing users to pass const strings.
>
> --
> v2- fixes per Joe Perches

Shouldn't that go below the --- line?

>
> Signed-off-by: Jim Cromie <jim.cromie@xxxxxxxxx>

Can you put a "Fixes:" tag in here?

thanks,

greg k-h