Re: [patch RFC 34/38] x86/msi: Let pci_msi_prepare() handle non-PCI MSI

From: Bjorn Helgaas
Date: Tue Aug 25 2020 - 17:50:50 EST


On Tue, Aug 25, 2020 at 11:30:41PM +0200, Thomas Gleixner wrote:
> On Tue, Aug 25 2020 at 15:24, Bjorn Helgaas wrote:
> > On Fri, Aug 21, 2020 at 02:24:58AM +0200, Thomas Gleixner wrote:
> >> Rename it to x86_msi_prepare() and handle the allocation type setup
> >> depending on the device type.
> >
> > I see what you're doing, but the subject reads a little strangely
>
> Yes :(
>
> > ("pci_msi_prepare() handling non-PCI" stuff) since it doesn't mention
> > the rename. Maybe not practical or worthwhile to split into a rename
> > + make generic, I dunno.
>
> What about
>
> x86/msi: Rename and rework pci_msi_prepare() to cover non-PCI MSI

Perfect!