Re: [PATCH V4] net: dsa: mt7530: Add of_node_put() before break and return statements

From: David Miller
Date: Tue Aug 25 2020 - 10:48:51 EST


From: Sumera Priyadarsini <sylphrenadin@xxxxxxxxx>
Date: Tue, 25 Aug 2020 01:33:11 +0530

> Every iteration of for_each_child_of_node() decrements
> the reference count of the previous node, however when control
> is transferred from the middle of the loop, as in the case of
> a return or break or goto, there is no decrement thus ultimately
> resulting in a memory leak.
>
> Fix a potential memory leak in mt7530.c by inserting of_node_put()
> before the break and return statements.
>
> Issue found with Coccinelle.
>
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@xxxxxxxxx>

Applied, thank you.