Re: [PATCH] netlink: remove duplicated nla_need_padding_for_64bit() check

From: linmiaohe
Date: Mon Aug 24 2020 - 07:58:38 EST


friendly ping :)

>Miaohe Lin <linmiaohe@xxxxxxxxxx> wrote:
>From: Miaohe Lin <linmiaohe@xxxxxxxxxx>
>
>The need for padding 64bit is implicitly checked by nla_align_64bit(), so remove this explicit one.
>
>Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
>---
> lib/nlattr.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/lib/nlattr.c b/lib/nlattr.c index bc5b5cf608c4..98f596bfbfd8 100644
>--- a/lib/nlattr.c
>+++ b/lib/nlattr.c
>@@ -816,8 +816,7 @@ EXPORT_SYMBOL(__nla_reserve); struct nlattr *__nla_reserve_64bit(struct sk_buff *skb, int attrtype,
> int attrlen, int padattr)
> {
>- if (nla_need_padding_for_64bit(skb))
>- nla_align_64bit(skb, padattr);
>+ nla_align_64bit(skb, padattr);
>
> return __nla_reserve(skb, attrtype, attrlen); }
>--
>2.19.1
>