Re: [PATCH v6 02/76] KVM: SVM: Add GHCB definitions

From: Borislav Petkov
Date: Mon Aug 24 2020 - 06:45:22 EST


On Mon, Aug 24, 2020 at 10:53:57AM +0200, Joerg Roedel wrote:
> static inline void __unused_size_checks(void)
> {
> - BUILD_BUG_ON(sizeof(struct vmcb_save_area) != 0x298);
> + BUILD_BUG_ON(sizeof(struct vmcb_save_area) != 1032);
> BUILD_BUG_ON(sizeof(struct vmcb_control_area) != 256);
> + BUILD_BUG_ON(sizeof(struct ghcb) != 4096);

Could those naked numbers be proper, meaningfully named defines?

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette