Re: [PATCH] ARM: dts: imx6sx-sdb: Add headphone detection for sound card

From: Shawn Guo
Date: Sun Aug 23 2020 - 19:57:49 EST


On Sun, Aug 23, 2020 at 11:12:08AM -0300, Fabio Estevam wrote:
> Hi Wang Shengjiu and Shawn,
>
> On Sun, Aug 23, 2020 at 9:31 AM S.j. Wang <shengjiu.wang@xxxxxxx> wrote:
>
> > I would like to know your opinion, should I move headphone detect GPIO
> > To audmux group?
>
> What about adding a dedicated pinctrl_hp for the headphone detect pin
> like it is done at:
> https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/tree/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi?h=for-next&id=8f0216b006e5f553d28c4c1a991b5234693a49cb#n130
>
> My point is that we should avoid adding a hog group when possible.

I agree. Hog group should be used as the last sort, when there is no
clear client device owning the pins.

Shawn