Re: [PATCH net-next] net: Remove unnecessary intermediate variables

From: Joe Perches
Date: Sat Aug 22 2020 - 17:03:46 EST


On Sat, 2020-08-22 at 13:59 -0700, David Miller wrote:
> From: Joe Perches <joe@xxxxxxxxxxx>
> Date: Sat, 22 Aug 2020 13:39:28 -0700
>
> > It _might_ be slightly faster to use inlines
>
> We are not using the inline directive in foo.c files and are letting
> the compiler decide.
>
> Please don't give out advice like this.

Actually, I checked with and without inline
before posting the proposal.

The compiler didn't inline the code without it.
Not even with just static inline.
For gcc 9.3 only the __always_inline did.
That's the only version I checked.